netdev - mdio: separate gpio-reset property per child phy usecase

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <SA1PR02MB85605C26380A9D8F4D1FB2AAC7859@SA1PR02MB8560.namprd02.prod.outlook.com>
Date:   Wed, 27 Oct 2021 12:58:55 +0000
From:   Radhey Shyam Pandey <radheys@...inx.com>
To:     "f.fainelli@...il.com" <f.fainelli@...il.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     Michal Simek <michals@...inx.com>,
        Harini Katakam <harinik@...inx.com>
Subject: mdio: separate gpio-reset property per child phy usecase

Hi all,

In a xilinx internal board we have shared GEM MDIO configuration with
TI DP83867 phy and for proper phy detection both PHYs need prior separate
GPIO-reset.

Description:
There are two GEM ethernet IPs instances GEM0 and GEM1. GEM0 and GEM1 used
shared MDIO driven by GEM1.

TI PHYs need prior reset (RESET_B) for PHY detection at defined address. 
However with current framework limitation " one reset line per PHY present 
on the MDIO bus" the other PHY get detected at incorrect address and later
having child PHY node reset property will also not help.

In order to fix this one possible solution is to allow reset-gpios 
property to have PHY reset GPIO tuple for each phy. If this
approach looks fine we can make changes and send out a RFC.

mdio: mdio {
 #address-cells = <1>;
#size-cells = <0>;
reset-gpios = <&slg7xl45106 5 GPIO_ACTIVE_HIGH>, 
<&slg7xl45106 6 GPIO_ACTIVE_HIGH>;
<snip>
 phy0: ethernet-phy@4 {
};
phy1: ethernet-phy@8 {
};
};

Thanks,
Radhey

> commit 4c5e7a2c0501bd531aad1d0378c589a92cb3cc31
> Author:     Florian Fainelli <f.fainelli@...il.com>
> AuthorDate: Tue Apr 25 11:33:03 2017 -0700
> Commit:     David S. Miller <davem@...emloft.net>
> CommitDate: Wed Apr 26 14:45:34 2017 -0400
> 
>      dt-bindings: mdio: Clarify binding document
> 
>      The described GPIO reset property is applicable to *all* child PHYs. If
>      we have one reset line per PHY present on the MDIO bus, these
>      automatically become properties of the child PHY nodes.
> 
>      Finally, indicate how the RESET pulse width must be defined, which is
>      the maximum value of all individual PHYs RESET pulse widths determined
>      by reading their datasheets.
> 
>      Fixes: 69226896ad63 ("mdio_bus: Issue GPIO RESET to PHYs.")
>      Signed-off-by: Florian Fainelli <f.fainelli@...il.com>
>      Reviewed-by: Roger Quadros <rogerq@...com>
>      Signed-off-by: David S. Miller <davem@...emloft.net>