netdev - Re: [EXT] Re: [net-next PATCH 1/2] octeontx2-pf: Add devlink param to init and de-init serdes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211027100857.4d25544c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Wed, 27 Oct 2021 10:08:57 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     sundeep subbaraya <sundeep.lkml@...il.com>
Cc:     David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
        hariprasad <hkelam@...vell.com>,
        Geetha sowjanya <gakula@...vell.com>,
        Sunil Kovvuri Goutham <sgoutham@...vell.com>,
        Subbaraya Sundeep <sbhatta@...vell.com>,
        Rakesh Babu <rsaladi2@...vell.com>,
        Saeed Mahameed <saeed@...nel.org>,
        "anthony.l.nguyen@...el.com" <anthony.l.nguyen@...el.com>,
        Jesse Brandeburg <jesse.brandeburg@...el.com>,
        Ido Schimmel <idosch@...sch.org>, Andrew Lunn <andrew@...n.ch>
Subject: Re: [EXT] Re: [net-next PATCH 1/2] octeontx2-pf: Add devlink param
 to init and de-init serdes

On Wed, 27 Oct 2021 22:13:32 +0530 sundeep subbaraya wrote:
> > On Wed, 27 Oct 2021 16:01:14 +0530 Subbaraya Sundeep wrote:  
> > > From: Rakesh Babu <rsaladi2@...vell.com>
> > >
> > > The physical/SerDes link of an netdev interface is not
> > > toggled on interface bring up and bring down. This is
> > > because the same link is shared between PFs and its VFs.
> > > This patch adds devlink param to toggle physical link so
> > > that it is useful in cases where a physical link needs to
> > > be re-initialized.  
> >
> > So it's a reset? Or are there cases where user wants the link
> > to stay down?  
> 
> There are cases where the user wants the link to stay down and debug.
> We are adding this to help customers to debug issues wrt physical links.

Intel has a similar thing, they keep adding a ethtool priv flag called 
"link-down-on-close" to all their drivers. Maybe others do this, too. 
It's time we added a standard API for this.