netdev - Re: [PATCH net-next 1/4] i40e: avoid spin loop in i40e_asq_send

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YXq3M5XvOkpMgiOg@cork>
Date:   Thu, 28 Oct 2021 07:44:03 -0700
From:   Jörn Engel <joern@...estorage.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Tony Nguyen <anthony.l.nguyen@...el.com>, davem@...emloft.net,
        Caleb Sander <csander@...estorage.com>, netdev@...r.kernel.org,
        sassmann@...hat.com, Tony Brelinski <tony.brelinski@...el.com>
Subject: Re: [PATCH net-next 1/4] i40e: avoid spin loop in
 i40e_asq_send_command()

On Thu, Oct 28, 2021 at 07:26:07AM -0700, Jakub Kicinski wrote:
> 
> The status of the command is re-checked after the loop, sleeping too
> long should not cause timeouts here.

Fair point.  usleep_range() is likely the correct answer in this case.

Jörn

--
It is the mark of an educated mind to be able to entertain a thought
without accepting it.
-- Aristotle