netdev - Re: [PATCH bpf] riscv, bpf: Fix potential NULL dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211028081621.1fb6bb31@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 28 Oct 2021 08:16:21 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Björn Töpel <bjorn@...nel.org>
Cc:     ast@...nel.org, daniel@...earbox.net, netdev@...r.kernel.org,
        bpf@...r.kernel.org, linux-riscv@...ts.infradead.org
Subject: Re: [PATCH bpf] riscv, bpf: Fix potential NULL dereference

On Thu, 28 Oct 2021 14:51:15 +0200 Björn Töpel wrote:
> The bpf_jit_binary_free() function requires a non-NULL argument. When
> the RISC-V BPF JIT fails to converge in NR_JIT_ITERATIONS steps,
> jit_data->header will be NULL, which triggers a NULL
> dereference. Avoid this by checking the argument, prior calling the
> function.
> 
> Fixes: ca6cb5447cec ("riscv, bpf: Factor common RISC-V JIT code")
> Signed-off-by: Björn Töpel <bjorn@...nel.org>

Looks pretty trivial so applied to net with Daniel's off-list blessing.