netdev - RE: [PATCH net] net: ethernet: microchip: lan743x: Increase rx ring size to improve rx performance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CH0PR11MB5561200392EC2B25B0D10F0E8E869@CH0PR11MB5561.namprd11.prod.outlook.com>
Date:   Thu, 28 Oct 2021 15:17:00 +0000
From:   <Yuiko.Oshino@...rochip.com>
To:     <kuba@...nel.org>
CC:     <davem@...emloft.net>, <netdev@...r.kernel.org>,
        <Bryan.Whitehead@...rochip.com>, <UNGLinuxDriver@...rochip.com>
Subject: RE: [PATCH net] net: ethernet: microchip: lan743x: Increase rx ring
 size to improve rx performance

>-----Original Message-----
>From: Jakub Kicinski <kuba@...nel.org>
>Sent: Thursday, October 28, 2021 11:14 AM
>To: Yuiko Oshino - C18177 <Yuiko.Oshino@...rochip.com>
>Cc: davem@...emloft.net; netdev@...r.kernel.org; Bryan Whitehead - C21958
><Bryan.Whitehead@...rochip.com>; UNGLinuxDriver
><UNGLinuxDriver@...rochip.com>
>Subject: Re: [PATCH net] net: ethernet: microchip: lan743x: Increase rx ring size
>to improve rx performance
>
>EXTERNAL EMAIL: Do not click links or open attachments unless you know the
>content is safe
>
>On Thu, 28 Oct 2021 11:03:15 -0400 Yuiko Oshino wrote:
>> Increase the rx ring size (LAN743X_RX_RING_SIZE) to improve rx performance
>on some platforms.
>> Tested on x86 PC with EVB-LAN7430.
>> The iperf3.7 TCPIP improved from 881 Mbps to 922 Mbps, and UDP improved
>from 817 Mbps to 936 Mbps.
>>
>> Fixes: 23f0703c125b ("lan743x: Add main source files for new lan743x
>> driver")
>> Signed-off-by: Yuiko Oshino <yuiko.oshino@...rochip.com>
>
>You seem to be posting performance optimizations as fixes.
>800Mbps is not "broken" for a 1G interface. Please remove the Fixes tag and re-
>post this with [PATCH net-next].
>
>Thank you!

Hi Jakub,
no problem.
Thank you for your comment.
Yuiko