netdev - Re: [PATCH net] net: ethernet: microchip: lan743x: Increase rx ring size to improve rx performance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YXrJxb0LtllPkOse@lunn.ch>
Date:   Thu, 28 Oct 2021 18:03:17 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Yuiko Oshino <yuiko.oshino@...rochip.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org,
        bryan.whitehead@...rochip.com, UNGLinuxDriver@...rochip.com
Subject: Re: [PATCH net] net: ethernet: microchip: lan743x: Increase rx ring
 size to improve rx performance

On Thu, Oct 28, 2021 at 11:03:15AM -0400, Yuiko Oshino wrote:
> Increase the rx ring size (LAN743X_RX_RING_SIZE) to improve rx performance on some platforms.
> Tested on x86 PC with EVB-LAN7430.
> The iperf3.7 TCPIP improved from 881 Mbps to 922 Mbps, and UDP improved from 817 Mbps to 936 Mbps.
> 
> Fixes: 23f0703c125b ("lan743x: Add main source files for new lan743x driver")
> Signed-off-by: Yuiko Oshino <yuiko.oshino@...rochip.com>
> ---
>  drivers/net/ethernet/microchip/lan743x_main.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/microchip/lan743x_main.h b/drivers/net/ethernet/microchip/lan743x_main.h
> index 34c22eea0124..aaf7aaeaba0c 100644
> --- a/drivers/net/ethernet/microchip/lan743x_main.h
> +++ b/drivers/net/ethernet/microchip/lan743x_main.h
> @@ -831,7 +831,7 @@ struct lan743x_rx_buffer_info {
>  	unsigned int    buffer_length;
>  };
>  
> -#define LAN743X_RX_RING_SIZE        (65)

65 is interesting. 2^N + 1. So there might be a reason for this?

> +#define LAN743X_RX_RING_SIZE        (128)

129?

	Andrew