netdev - RE: [RFC v5 net-next 2/5] rtnetlink: Add new RTM_GETEECSTATE message to get SyncE status

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <MW5PR11MB581227D73C9FD010A50759AEEA869@MW5PR11MB5812.namprd11.prod.outlook.com>
Date:   Thu, 28 Oct 2021 06:34:26 +0000
From:   "Machnikowski, Maciej" <maciej.machnikowski@...el.com>
To:     Ido Schimmel <idosch@...sch.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
        "richardcochran@...il.com" <richardcochran@...il.com>,
        "abyagowi@...com" <abyagowi@...com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "linux-kselftest@...r.kernel.org" <linux-kselftest@...r.kernel.org>,
        "mkubecek@...e.cz" <mkubecek@...e.cz>,
        "saeed@...nel.org" <saeed@...nel.org>,
        "michael.chan@...adcom.com" <michael.chan@...adcom.com>
Subject: RE: [RFC v5 net-next 2/5] rtnetlink: Add new RTM_GETEECSTATE message
 to get SyncE status

> -----Original Message-----
> From: Ido Schimmel <idosch@...sch.org>
> Sent: Wednesday, October 27, 2021 5:11 PM
> To: Machnikowski, Maciej <maciej.machnikowski@...el.com>
> Cc: netdev@...r.kernel.org; intel-wired-lan@...ts.osuosl.org;
> richardcochran@...il.com; abyagowi@...com; Nguyen, Anthony L
> <anthony.l.nguyen@...el.com>; davem@...emloft.net; kuba@...nel.org;
> linux-kselftest@...r.kernel.org; mkubecek@...e.cz; saeed@...nel.org;
> michael.chan@...adcom.com
> Subject: Re: [RFC v5 net-next 2/5] rtnetlink: Add new RTM_GETEECSTATE
> message to get SyncE status
> 
> On Wed, Oct 27, 2021 at 01:16:22PM +0000, Machnikowski, Maciej wrote:
> >
> >
> > > -----Original Message-----
> > > From: Ido Schimmel <idosch@...sch.org>
> > > Sent: Wednesday, October 27, 2021 9:10 AM
> > > To: Machnikowski, Maciej <maciej.machnikowski@...el.com>
> > > Subject: Re: [RFC v5 net-next 2/5] rtnetlink: Add new RTM_GETEECSTATE
> > > message to get SyncE status
> > >
> > > On Tue, Oct 26, 2021 at 07:31:43PM +0200, Maciej Machnikowski wrote:
> > > > +/* SyncE section */
> > > > +
> > > > +enum if_eec_state {
> > > > +	IF_EEC_STATE_INVALID = 0,
> > > > +	IF_EEC_STATE_FREERUN,
> > > > +	IF_EEC_STATE_LOCKED,
> > > > +	IF_EEC_STATE_LOCKED_HO_ACQ,
> > >
> > > Is this referring to "Locked mode, acquiring holdover: This is a
> > > temporary mode, when coming from free-run, to acquire holdover
> > > memory."
> > > ?
> >
> > Locked HO ACQ means locked and holdover acquired. It's the state that
> > allows transferring to the holdover state. Locked means that we locked
> > our frequency and started acquiring the holdover memory.
> 
> So that's a transient state, right? FWIW, I find it weird to call such a
> state "LOCKED".
> 
> >
> > > It seems ice isn't using it, so maybe drop it? Can be added later in
> > > case we have a driver that can report it
> >
> > I'll update the driver in the next revision
> 
> You mean update it to use "IF_EEC_STATE_LOCKED_HO_ACQ" instead of
> "IF_EEC_STATE_LOCKED"?

Rather report them separately - as there's a value in having info about both 
of them. LOCKED_HO_ACQ can be forced into forced holdover, while the 
LOCKED will revert to freerun.

> Regardless, would be good to document these values.

Noted! :)

> >
> > > There is also "Locked mode, holdover acquired: This is a steady state
> > > mode, entered when holdover memory is acquired." But I assume that's
> > > "IF_EEC_STATE_LOCKED"
> > >
> > > > +	IF_EEC_STATE_HOLDOVER,
> > > > +};