netdev - Re: [PATCH net-next 6/6] mctp i2c: MCTP I2C binding driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5650511d-f6aa-97a4-ce82-060c2c51afb5@infradead.org>
Date:   Mon, 1 Nov 2021 06:22:39 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Matt Johnston <matt@...econstruct.com.au>
Cc:     Zev Weiss <zev@...ilderbeest.net>, Wolfram Sang <wsa@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Brendan Higgins <brendanhiggins@...gle.com>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Joel Stanley <joel@....id.au>,
        Andrew Jeffery <andrew@...id.au>,
        Avi Fishman <avifishman70@...il.com>,
        Tomer Maimon <tmaimon77@...il.com>,
        Tali Perry <tali.perry1@...il.com>,
        Patrick Venture <venture@...gle.com>,
        Nancy Yuen <yuenn@...gle.com>,
        Benjamin Fair <benjaminfair@...gle.com>,
        Jeremy Kerr <jk@...econstruct.com.au>,
        linux-i2c@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 6/6] mctp i2c: MCTP I2C binding driver

Hi--

On 11/1/21 2:04 AM, Matt Johnston wrote:
> diff --git a/drivers/net/mctp/Kconfig b/drivers/net/mctp/Kconfig
> index d8f966cedc89..a468ba7c2f0b 100644
> --- a/drivers/net/mctp/Kconfig
> +++ b/drivers/net/mctp/Kconfig
> @@ -3,6 +3,18 @@ if MCTP
>   
>   menu "MCTP Device Drivers"
>   
> +config MCTP_TRANSPORT_I2C
> +	tristate "MCTP SMBus/I2C transport"
> +	# i2c-mux is optional, but we must build as a module if i2c-mux is a module
> +	depends on !I2C_MUX || I2C_MUX=y || m

I'm fairly sure that the ending "m" there forces this to always be built
as a loadable module.  Is that what you meant to do here?

Maybe you want something like this?

	depends on I2C_MUX || !I2C_MUX

That should limit how this driver can be built if I2C_MUX is m.

> +	depends on I2C
> +	depends on I2C_SLAVE
> +	select MCTP_FLOWS
> +	help
> +	  Provides a driver to access MCTP devices over SMBus/I2C transport,
> +	  from DMTF specification DSP0237. A MCTP protocol network device is
> +	  created for each I2C bus that has been assigned a mctp-i2c device.


-- 
~Randy