netdev - Re: [PATCH net-next 6/6] mctp i2c: MCTP I2C binding driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <49f5ecb1ab4ba4b28c875ec1d40aa57991907b0f.camel@codeconstruct.com.au>
Date:   Tue, 02 Nov 2021 14:48:41 +0800
From:   Matt Johnston <matt@...econstruct.com.au>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     Zev Weiss <zev@...ilderbeest.net>, Wolfram Sang <wsa@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Brendan Higgins <brendanhiggins@...gle.com>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Joel Stanley <joel@....id.au>,
        Andrew Jeffery <andrew@...id.au>,
        Avi Fishman <avifishman70@...il.com>,
        Tomer Maimon <tmaimon77@...il.com>,
        Tali Perry <tali.perry1@...il.com>,
        Patrick Venture <venture@...gle.com>,
        Nancy Yuen <yuenn@...gle.com>,
        Benjamin Fair <benjaminfair@...gle.com>,
        Jeremy Kerr <jk@...econstruct.com.au>,
        linux-i2c@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 6/6] mctp i2c: MCTP I2C binding driver

Hi Randy,

> > +config MCTP_TRANSPORT_I2C
> > +	tristate "MCTP SMBus/I2C transport"
> > +	# i2c-mux is optional, but we must build as a module if i2c-mux is a module
> > +	depends on !I2C_MUX || I2C_MUX=y || m
> 
> I'm fairly sure that the ending "m" there forces this to always be built
> as a loadable module.  Is that what you meant to do here?
> 
> Maybe you want something like this?
> 
> 	depends on I2C_MUX || !I2C_MUX

Checking here it behaves as intended, this gives mctp-i2c built-in:
CONFIG_I2C_MUX=y
CONFIG_MCTP_TRANSPORT_I2C=y

Setting CONFIG_I2C_MUX=m forces CONFIG_MCTP_TRANSPORT_I2C=m. 

Though I will change it to your suggestion since that's more concise.

Cheers,
Matt