netdev - Re: [PATCH net-next 0/5] Code movement to br

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YYACSc+qv2jMzg/B@nanopsycho>
Date:   Mon, 1 Nov 2021 16:05:45 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Vladimir Oltean <vladimir.oltean@....com>
Cc:     netdev@...r.kernel.org, Jakub Kicinski <kuba@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Roopa Prabhu <roopa@...dia.com>,
        Nikolay Aleksandrov <nikolay@...dia.com>,
        Jiri Pirko <jiri@...dia.com>, Ido Schimmel <idosch@...dia.com>
Subject: Re: [PATCH net-next 0/5] Code movement to br_switchdev.c

Wed, Oct 27, 2021 at 06:21:14PM CEST, vladimir.oltean@....com wrote:
>This is one more refactoring patch set for the Linux bridge, where more
>logic that is specific to switchdev is moved into br_switchdev.c, which
>is compiled out when CONFIG_NET_SWITCHDEV is disabled.

Looks good.

While you are at it, don't you plan to also move switchdev.c into
br_switchdev.c and eventually rename to br_offload.c ?

Switchdev is about bridge offloading only anyway.


>
>Vladimir Oltean (5):
>  net: bridge: provide shim definition for br_vlan_flags
>  net: bridge: move br_vlan_replay to br_switchdev.c
>  net: bridge: split out the switchdev portion of br_mdb_notify
>  net: bridge: mdb: move all switchdev logic to br_switchdev.c
>  net: bridge: switchdev: consistent function naming
>
> net/bridge/br_mdb.c       | 238 +-----------------------
> net/bridge/br_private.h   |  28 ++-
> net/bridge/br_switchdev.c | 371 ++++++++++++++++++++++++++++++++++++--
> net/bridge/br_vlan.c      |  84 ---------
> 4 files changed, 372 insertions(+), 349 deletions(-)
>
>-- 
>2.25.1
>