netdev - Re: [PATCH net-next 0/5] Code movement to br

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211102111159.f5rxiqxnramrnerh@skbuf>
Date:   Tue, 2 Nov 2021 11:11:59 +0000
From:   Vladimir Oltean <vladimir.oltean@....com>
To:     Jiri Pirko <jiri@...nulli.us>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Jakub Kicinski <kuba@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Roopa Prabhu <roopa@...dia.com>,
        Nikolay Aleksandrov <nikolay@...dia.com>,
        Jiri Pirko <jiri@...dia.com>, Ido Schimmel <idosch@...dia.com>
Subject: Re: [PATCH net-next 0/5] Code movement to br_switchdev.c

On Mon, Nov 01, 2021 at 04:05:45PM +0100, Jiri Pirko wrote:
> Wed, Oct 27, 2021 at 06:21:14PM CEST, vladimir.oltean@....com wrote:
> >This is one more refactoring patch set for the Linux bridge, where more
> >logic that is specific to switchdev is moved into br_switchdev.c, which
> >is compiled out when CONFIG_NET_SWITCHDEV is disabled.
> 
> Looks good.
> 
> While you are at it, don't you plan to also move switchdev.c into
> br_switchdev.c and eventually rename to br_offload.c ?
> 
> Switchdev is about bridge offloading only anyway.

You mean I should effectively make switchdev part of the bridge?
See commit 957e2235e526 ("net: make switchdev_bridge_port_{,unoffload}
loosely coupled with the bridge").