netdev - Re: [PATCH V5 net-next 0/6] ethtool: add support to set/get tx copybreak buf size and rx buf len

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 1 Nov 2021 11:42:18 +0800
From:   "huangguangbin (A)" <huangguangbin2@...wei.com>
To:     Andrew Lunn <andrew@...n.ch>
CC:     <davem@...emloft.net>, <kuba@...nel.org>, <mkubecek@...e.cz>,
        <amitc@...lanox.com>, <idosch@...sch.org>, <danieller@...dia.com>,
        <jesse.brandeburg@...el.com>, <anthony.l.nguyen@...el.com>,
        <jdike@...toit.com>, <richard@....at>,
        <anton.ivanov@...bridgegreys.com>, <netanel@...zon.com>,
        <akiyano@...zon.com>, <gtzalik@...zon.com>, <saeedb@...zon.com>,
        <chris.snook@...il.com>, <ulli.kroll@...glemail.com>,
        <linus.walleij@...aro.org>, <jeroendb@...gle.com>,
        <csully@...gle.com>, <awogbemila@...gle.com>, <jdmason@...zu.us>,
        <rain.1986.08.12@...il.com>, <zyjzyj2000@...il.com>,
        <kys@...rosoft.com>, <haiyangz@...rosoft.com>, <mst@...hat.com>,
        <jasowang@...hat.com>, <doshir@...are.com>,
        <pv-drivers@...are.com>, <jwi@...ux.ibm.com>,
        <kgraul@...ux.ibm.com>, <hca@...ux.ibm.com>, <gor@...ux.ibm.com>,
        <johannes@...solutions.net>, <netdev@...r.kernel.org>,
        <lipeng321@...wei.com>, <chenhao288@...ilicon.com>,
        <linux-s390@...r.kernel.org>
Subject: Re: [PATCH V5 net-next 0/6] ethtool: add support to set/get tx
 copybreak buf size and rx buf len



On 2021/10/31 1:58, Andrew Lunn wrote:
>> Rx buf len is buffer length of each rx BD. Use ethtool -g command to get
>> it, and ethtool -G command to set it, examples are as follow:
>>
>> 1. set rx buf len to 4096
>> $ ethtool -G eth1 rx-buf-len 4096
>>
>> 2. get rx buf len
>> $ ethtool -g eth1
>> ...
>> RX Buf Len:     4096
> 
> How does this interact with MTU? If i have an MTU of 1500, and i set
> the rx-buf-len to 1000, can i expect all frames to the discarded?
> Should the core return -EINVAL? Or do you think some hardware will
> simply allocate two buffers and scatter/gather over them? Which
> implies that drivers which cannot SG must check if the rx-buf-len is
> less than the MTU and return -EINVAL?
> 
>       Andrew
> .
> 
Yes, hns3 driver supports scatter/gather for this situation, it's necessary
for driver which cannot support SG to check if rx buf len is less than mtu.