netdev - Re: [PATCH V5 net-next 6/6] net: hns3: remove the way to set tx spare buf via module parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <84f977be-d2df-0927-fb43-c7afae373bd1@huawei.com>
Date:   Mon, 1 Nov 2021 11:43:41 +0800
From:   "huangguangbin (A)" <huangguangbin2@...wei.com>
To:     Andrew Lunn <andrew@...n.ch>
CC:     <davem@...emloft.net>, <kuba@...nel.org>, <mkubecek@...e.cz>,
        <amitc@...lanox.com>, <idosch@...sch.org>, <danieller@...dia.com>,
        <jesse.brandeburg@...el.com>, <anthony.l.nguyen@...el.com>,
        <jdike@...toit.com>, <richard@....at>,
        <anton.ivanov@...bridgegreys.com>, <netanel@...zon.com>,
        <akiyano@...zon.com>, <gtzalik@...zon.com>, <saeedb@...zon.com>,
        <chris.snook@...il.com>, <ulli.kroll@...glemail.com>,
        <linus.walleij@...aro.org>, <jeroendb@...gle.com>,
        <csully@...gle.com>, <awogbemila@...gle.com>, <jdmason@...zu.us>,
        <rain.1986.08.12@...il.com>, <zyjzyj2000@...il.com>,
        <kys@...rosoft.com>, <haiyangz@...rosoft.com>, <mst@...hat.com>,
        <jasowang@...hat.com>, <doshir@...are.com>,
        <pv-drivers@...are.com>, <jwi@...ux.ibm.com>,
        <kgraul@...ux.ibm.com>, <hca@...ux.ibm.com>, <gor@...ux.ibm.com>,
        <johannes@...solutions.net>, <netdev@...r.kernel.org>,
        <lipeng321@...wei.com>, <chenhao288@...ilicon.com>,
        <linux-s390@...r.kernel.org>
Subject: Re: [PATCH V5 net-next 6/6] net: hns3: remove the way to set tx spare
 buf via module parameter



On 2021/10/31 2:05, Andrew Lunn wrote:
> On Sat, Oct 30, 2021 at 09:10:01PM +0800, Guangbin Huang wrote:
>> From: Hao Chen <chenhao288@...ilicon.com>
>>
>> The way to set tx spare buf via module parameter is not such
>> convenient as the way to set it via ethtool.
>>
>> So,remove the way to set tx spare buf via module parameter.
>>
>> Signed-off-by: Hao Chen <chenhao288@...ilicon.com>
>> Signed-off-by: Guangbin Huang <huangguangbin2@...wei.com>
>> ---
>>   drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 7 +------
>>   1 file changed, 1 insertion(+), 6 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
>> index 076631d7727d..032547a2ad2f 100644
>> --- a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
>> +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
>> @@ -53,10 +53,6 @@ static int debug = -1;
>>   module_param(debug, int, 0);
>>   MODULE_PARM_DESC(debug, " Network interface message level setting");
>>   
>> -static unsigned int tx_spare_buf_size;
>> -module_param(tx_spare_buf_size, uint, 0400);
>> -MODULE_PARM_DESC(tx_spare_buf_size, "Size used to allocate tx spare buffer");
>> -
> 
> This might be considered ABI. By removing it, are you breaking users
> setup?
> 
> 	Andrew
> .
> 
Yes, patch 1/6 and 2/6 add support for ethtool to set tx spare(copybreak) buf size,
so remove the way to set it by module parameter.