netdev - Re: [PATCH] module: Fix implicit type conversion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211109212556.GX174703@worktop.programming.kicks-ass.net>
Date:   Tue, 9 Nov 2021 22:25:56 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     Luis Chamberlain <mcgrof@...nel.org>
Cc:     Miroslav Benes <mbenes@...e.cz>,
        Julia Lawall <julia.lawall@...ia.fr>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        Thomas Gleixner <tglx@...utronix.de>,
        Jiasheng Jiang <jiasheng@...as.ac.cn>, jeyu@...nel.org,
        ast@...nel.org, daniel@...earbox.net, andrii@...nel.org,
        kafai@...com, songliubraving@...com, yhs@...com,
        john.fastabend@...il.com, kpsingh@...nel.org, nathan@...nel.org,
        ndesaulniers@...gle.com, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org, bpf@...r.kernel.org,
        clang-built-linux@...glegroups.com
Subject: Re: [PATCH] module: Fix implicit type conversion

On Tue, Nov 09, 2021 at 12:56:38PM -0800, Luis Chamberlain wrote:

> If we're going to do this we we must ask, is it really worth it and
> moving forward then add a semantic patch rule which will pick up on
> misuses.

Please, no!

This guy has been going around sending silly patches on his own, but the
moment you add this script all the robots will join him, adding to the
pile of useless crap we get to wade through each day.

I've yet to see one of these patches fix an actual problem.