netdev - Re: [PATCH net] selftests: forwarding: Fix packet matching in mirroring selftests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 10 Nov 2021 16:22:25 +0100
From:   Petr Machata <petrm@...dia.com>
To:     Jamal Hadi Salim <jhs@...atatu.com>
CC:     Petr Machata <petrm@...dia.com>, <netdev@...r.kernel.org>,
        Jiri Pirko <jiri@...nulli.us>,
        Cong Wang <xiyou.wangcong@...il.com>,
        David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, <komachi.yoshiki@...il.com>,
        Toshiaki Makita <makita.toshiaki@....ntt.co.jp>
Subject: Re: [PATCH net] selftests: forwarding: Fix packet matching in
 mirroring selftests


Jamal Hadi Salim <jhs@...atatu.com> writes:

> While it makes sense to look at outer header - every other script
> out in the wild (including your selftests) assumed inner header.

It didn't so much make assumptions as happened to work despite being
buggy. But yeah, fair point.