netdev - Re: [PATCH net] selftests: forwarding: Fix packet matching in mirroring selftests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <63920e68-18ed-f949-dc1a-c1cc2013e772@mojatatu.com>
Date:   Fri, 12 Nov 2021 06:50:37 -0500
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     Petr Machata <petrm@...dia.com>
Cc:     netdev@...r.kernel.org, Jiri Pirko <jiri@...nulli.us>,
        Cong Wang <xiyou.wangcong@...il.com>,
        David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, komachi.yoshiki@...il.com,
        Toshiaki Makita <makita.toshiaki@....ntt.co.jp>
Subject: Re: [PATCH net] selftests: forwarding: Fix packet matching in
 mirroring selftests

On 2021-11-10 10:22, Petr Machata wrote:
> 
> Jamal Hadi Salim <jhs@...atatu.com> writes:
> 
>> While it makes sense to look at outer header - every other script
>> out in the wild (including your selftests) assumed inner header.
> 
> It didn't so much make assumptions as happened to work despite being
> buggy. But yeah, fair point.
> 

The problem is before this patch when the tc flower command referenced
an IP address it was for the inner header. With this change the same
command now is implying outer header.

cheers,
jamal