netdev - Re: [PATCH iproute2] ip/ipnexthop: fix unsigned overflow in parse_nh_group_type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YZYZd7ybCb98+XoT@shredder>
Date:   Thu, 18 Nov 2021 11:14:31 +0200
From:   Ido Schimmel <idosch@...sch.org>
To:     Maxim Petrov <mmrmaximuzz@...il.com>
Cc:     netdev@...r.kernel.org,
        Stephen Hemminger <stephen@...workplumber.org>,
        David Miller <davem@...emloft.net>
Subject: Re: [PATCH iproute2] ip/ipnexthop: fix unsigned overflow in
 parse_nh_group_type_res()

On Wed, Nov 17, 2021 at 10:11:24PM +0300, Maxim Petrov wrote:
> 0UL has type 'unsigned long' which is likely to be 64bit on modern machines. At
> the same time, the '{idle,unbalanced}_timer' variables are declared as u32, so
> these variables cannot be greater than '~0UL / 100' when 'unsigned long' is 64
> bits. In such condition it is still possible to pass the check but get the
> overflow later when the timers are multiplied by 100 in 'addattr32'.
> 
> Fix the possible overflow by changing '~0UL' to 'UINT32_MAX'.
> 
> Signed-off-by: Maxim Petrov <mmrmaximuzz@...il.com>

Reviewed-by: Ido Schimmel <idosch@...dia.com>