netdev - Re: [PATCH] Revert "net: ethernet: bgmac: Use devm_platform_ioremap_resource

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 18 Nov 2021 10:14:31 +0100
From:   Jonas Gorski <jonas.gorski@...il.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Rafał Miłecki <rafal@...ecki.pl>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Yang Yingliang <yangyingliang@...wei.com>,
        Dejin Zheng <zhengdejin5@...il.com>,
        Network Development <netdev@...r.kernel.org>,
        bcm-kernel-feedback-list <bcm-kernel-feedback-list@...adcom.com>
Subject: Re: [PATCH] Revert "net: ethernet: bgmac: Use devm_platform_ioremap_resource_byname"

Hi Andrew,

On Wed, 17 Nov 2021 at 17:42, Andrew Lunn <andrew@...n.ch> wrote:
>
> On Wed, Nov 17, 2021 at 05:07:18PM +0100, Jonas Gorski wrote:
> > This reverts commit 3710e80952cf2dc48257ac9f145b117b5f74e0a5.
> >
> > Since idm_base and nicpm_base are still optional resources not present
> > on all platforms, this breaks the driver for everything except Northstar
> > 2 (which has both).
> >
> > The same change was already reverted once with 755f5738ff98 ("net:
> > broadcom: fix a mistake about ioremap resource").
> >
> > So let's do it again.
>
> Hi Jonas
>
> It is worth adding a comment in the code about them being optional. It
> seems like bot handlers are dumber than the bots they use, but they
> might read a comment and not make the same mistake a 3rd time.

Sounds reasonable, will spin a v2 with a comment added.

Regards
Jonas