netdev - Re: [PATCH net-next iproute2] vdpa: Remove duplicate vdpa UAPI header file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211118081844.19bb7a96@hermes.local>
Date:   Thu, 18 Nov 2021 08:18:44 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Parav Pandit <parav@...dia.com>
Cc:     <dsahern@...il.com>, <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next iproute2] vdpa: Remove duplicate vdpa UAPI
 header file

On Sat, 6 Nov 2021 08:41:52 +0200
Parav Pandit <parav@...dia.com> wrote:

> vdpa header file is already present in the tree at
> vdpa/include/uapi/linux/vdpa.h and used by vdpa/vdpa.c.
> 
> As we discussed in thread [1] vdpa header comes from a different
> tree, similar to rdma subsystem. Hence remove the duplicate vdpa
> UAPI header file.
> 
> [1] https://www.spinics.net/lists/netdev/msg748458.html
> 
> Fixes: b5a6ed9cc9fc ("uapi: add missing virtio related headers")
> Signed-off-by: Parav Pandit <parav@...dia.com>
> ---
>  include/uapi/linux/vdpa.h | 40 ---------------------------------------
>  1 file changed, 40 deletions(-)
>  delete mode 100644 include/uapi/linux/vdpa.h

Ok, but the vdpa.h needs to be kept updated, let me add that
subtree to my update-headers script.

The update headers script does 'make install_headers' in the
Linux kernel tree then clones them to iproute2.

I would prefer that Rdma and Vdpa do not have their own
headers. The future chance of version skew is too high.
For now, the tool will update all three locations.