netdev - RE: [PATCH net-next iproute2] vdpa: Remove duplicate vdpa UAPI header file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 18 Nov 2021 04:21:52 +0000
From:   Parav Pandit <parav@...dia.com>
To:     Parav Pandit <parav@...dia.com>,
        "dsahern@...il.com" <dsahern@...il.com>,
        "stephen@...workplumber.org" <stephen@...workplumber.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH net-next iproute2] vdpa: Remove duplicate vdpa UAPI header
 file

Hi David, Stephen,

> From: Parav Pandit <parav@...dia.com>
> Sent: Saturday, November 6, 2021 12:12 PM
> 
> vdpa header file is already present in the tree at
> vdpa/include/uapi/linux/vdpa.h and used by vdpa/vdpa.c.
> 
> As we discussed in thread [1] vdpa header comes from a different tree, similar
> to rdma subsystem. Hence remove the duplicate vdpa UAPI header file.
> 
[..]

> 
> Fixes: b5a6ed9cc9fc ("uapi: add missing virtio related headers")
> Signed-off-by: Parav Pandit <parav@...dia.com>

Can you please review this fix?
I need to submit further extensions to vdpa tool that needs header update; and above fix is necessary.

> ---
>  include/uapi/linux/vdpa.h | 40 ---------------------------------------
>  1 file changed, 40 deletions(-)
>  delete mode 100644 include/uapi/linux/vdpa.h
> 
> diff --git a/include/uapi/linux/vdpa.h b/include/uapi/linux/vdpa.h deleted file
> mode 100644 index 37ae26b6..00000000
> --- a/include/uapi/linux/vdpa.h
> +++ /dev/null
> @@ -1,40 +0,0 @@
> -/* SPDX-License-Identifier: GPL-2.0+ WITH Linux-syscall-note */
> -/*
> - * vdpa device management interface
> - * Copyright (c) 2020 Mellanox Technologies Ltd. All rights reserved.
> - */
> -
> -#ifndef _LINUX_VDPA_H_
> -#define _LINUX_VDPA_H_
> -
> -#define VDPA_GENL_NAME "vdpa"
> -#define VDPA_GENL_VERSION 0x1
> -
> -enum vdpa_command {
> -	VDPA_CMD_UNSPEC,
> -	VDPA_CMD_MGMTDEV_NEW,
> -	VDPA_CMD_MGMTDEV_GET,		/* can dump */
> -	VDPA_CMD_DEV_NEW,
> -	VDPA_CMD_DEV_DEL,
> -	VDPA_CMD_DEV_GET,		/* can dump */
> -};
> -
> -enum vdpa_attr {
> -	VDPA_ATTR_UNSPEC,
> -
> -	/* bus name (optional) + dev name together make the parent device
> handle */
> -	VDPA_ATTR_MGMTDEV_BUS_NAME,		/* string */
> -	VDPA_ATTR_MGMTDEV_DEV_NAME,		/* string */
> -	VDPA_ATTR_MGMTDEV_SUPPORTED_CLASSES,	/* u64 */
> -
> -	VDPA_ATTR_DEV_NAME,			/* string */
> -	VDPA_ATTR_DEV_ID,			/* u32 */
> -	VDPA_ATTR_DEV_VENDOR_ID,		/* u32 */
> -	VDPA_ATTR_DEV_MAX_VQS,			/* u32 */
> -	VDPA_ATTR_DEV_MAX_VQ_SIZE,		/* u16 */
> -
> -	/* new attributes must be added above here */
> -	VDPA_ATTR_MAX,
> -};
> -
> -#endif
> --
> 2.26.2