netdev - Re: [PATCH v2] net: ethernet: dec: tulip: de4x5: fix possible array overflows in type3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a3HsvNe2Rkpx9DqDRLpxCFrOi8hx5iAhJziwOQcKj-Ltw@mail.gmail.com>
Date:   Thu, 18 Nov 2021 08:05:51 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Teng Qi <starmiku1207184332@...il.com>
Cc:     David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, tanghui20@...wei.com,
        Arnd Bergmann <arnd@...db.de>,
        Networking <netdev@...r.kernel.org>,
        Parisc List <linux-parisc@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Jia-Ju Bai <baijiaju1990@...il.com>, islituo@...il.com,
        TOTE Robot <oslab@...nghua.edu.cn>
Subject: Re: [PATCH v2] net: ethernet: dec: tulip: de4x5: fix possible array
 overflows in type3_infoblock()

On Thu, Nov 18, 2021 at 8:01 AM Teng Qi <starmiku1207184332@...il.com> wrote:
>
> The definition of macro MOTO_SROM_BUG is:
>   #define MOTO_SROM_BUG    (lp->active == 8 && (get_unaligned_le32(
>   dev->dev_addr) & 0x00ffffff) == 0x3e0008)
>
> and the if statement
>   if (MOTO_SROM_BUG) lp->active = 0;
>
> using this macro indicates lp->active could be 8. If lp->active is 8 and
> the second comparison of this macro is false. lp->active will remain 8 in:
>   lp->phy[lp->active].gep = (*p ? p : NULL); p += (2 * (*p) + 1);
>   lp->phy[lp->active].rst = (*p ? p : NULL); p += (2 * (*p) + 1);
>   lp->phy[lp->active].mc  = get_unaligned_le16(p); p += 2;
>   lp->phy[lp->active].ana = get_unaligned_le16(p); p += 2;
>   lp->phy[lp->active].fdx = get_unaligned_le16(p); p += 2;
>   lp->phy[lp->active].ttm = get_unaligned_le16(p); p += 2;
>   lp->phy[lp->active].mci = *p;
>
> However, the length of array lp->phy is 8, so array overflows can occur.
> To fix these possible array overflows, we first check lp->active and then
> return -EINVAL if it is greater or equal to ARRAY_SIZE(lp->phy) (i.e. 8).
>
> Reported-by: TOTE Robot <oslab@...nghua.edu.cn>
> Signed-off-by: Teng Qi <starmiku1207184332@...il.com>

Reviewed-by: Arnd Bergmann <arnd@...db.de>