lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 18 Nov 2021 15:11:28 +0800 From: Guo Zhengkui <guozhengkui@...o.com> To: daniel@...earbox.net Cc: andrii@...nel.org, ast@...nel.org, bpf@...r.kernel.org, davemarchevsky@...com, guozhengkui@...o.com, john.fastabend@...il.com, kafai@...com, kernel@...o.com, kpsingh@...nel.org, linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org, netdev@...r.kernel.org, shuah@...nel.org, songliubraving@...com, sunyucong@...il.com, yhs@...com Subject: Re: [PATCH] selftests/bpf: fix array_size.cocci warning > No need for the extra include. test_progs.h already includes bpf_util.h, please check > such trivialities before submission. Simple grep would have revealed use of ARRAY_SIZE() > in various places under tools/testing/selftests/bpf/prog_tests/. Actually, ARRAY_SIZE() in ./include/linux/kernel.h is diffrent from the one defined in bpf_util.h: ./include/linux/kernel.h #define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]) + __must_be_array(arr)) ./tools/testing/selftests/bpf/bpf_util.h #define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0])) __must_be_array() ensures arr is an array, which is better than the one defined in bpf_util.h > here are many more similar occurrences. Please just send one cleanup patch to reduce churn in the git log. Yes, I will commit another patch.
Powered by blists - more mailing lists