netdev - Re: [PATCH net] qede: validate non LSO skb length

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211124153816.124156fc@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Wed, 24 Nov 2021 15:38:16 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Manish Chopra <manishc@...vell.com>
Cc:     <netdev@...r.kernel.org>, <aelior@...vell.com>,
        <palok@...vell.com>, <pkushwaha@...vell.com>
Subject: Re: [PATCH net] qede: validate non LSO skb length

On Wed, 24 Nov 2021 01:24:05 -0800 Manish Chopra wrote:
> Although it is unlikely that stack could transmit a non LSO
> skb with length > MTU, however in some cases or environment such
> occurrences actually resulted into firmware asserts due to packet
> length being greater than the max supported by the device (~9700B).
> 
> This patch adds the safeguard for such odd cases to avoid firmware
> asserts.
> 
> Signed-off-by: Manish Chopra <manishc@...vell.com>
> Signed-off-by: Alok Prasad <palok@...vell.com>
> Signed-off-by: Prabhakar Kushwaha <pkushwaha@...vell.com>
> Signed-off-by: Ariel Elior <aelior@...vell.com>

Please add an appropriate Fixes tag and repost.