netdev - RE: [EXT] Re: [PATCH net] qede: validate non LSO skb length

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BY3PR18MB4612B62FDA2167BB348D4051AB699@BY3PR18MB4612.namprd18.prod.outlook.com>
Date:   Thu, 2 Dec 2021 21:19:26 +0000
From:   Manish Chopra <manishc@...vell.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Ariel Elior <aelior@...vell.com>,
        Alok Prasad <palok@...vell.com>,
        Prabhakar Kushwaha <pkushwaha@...vell.com>
Subject: RE: [EXT] Re: [PATCH net] qede: validate non LSO skb length

> -----Original Message-----
> From: Jakub Kicinski <kuba@...nel.org>
> Sent: Thursday, November 25, 2021 5:08 AM
> To: Manish Chopra <manishc@...vell.com>
> Cc: netdev@...r.kernel.org; Ariel Elior <aelior@...vell.com>; Alok Prasad
> <palok@...vell.com>; Prabhakar Kushwaha <pkushwaha@...vell.com>
> Subject: [EXT] Re: [PATCH net] qede: validate non LSO skb length
> 
> External Email
> 
> ----------------------------------------------------------------------
> On Wed, 24 Nov 2021 01:24:05 -0800 Manish Chopra wrote:
> > Although it is unlikely that stack could transmit a non LSO skb with
> > length > MTU, however in some cases or environment such occurrences
> > actually resulted into firmware asserts due to packet length being
> > greater than the max supported by the device (~9700B).
> >
> > This patch adds the safeguard for such odd cases to avoid firmware
> > asserts.
> >
> > Signed-off-by: Manish Chopra <manishc@...vell.com>
> > Signed-off-by: Alok Prasad <palok@...vell.com>
> > Signed-off-by: Prabhakar Kushwaha <pkushwaha@...vell.com>
> > Signed-off-by: Ariel Elior <aelior@...vell.com>
> 
> Please add an appropriate Fixes tag and repost.

Hello Jakub,

I don't really know which commit has introduced this exactly. It was probably day1 (when this driver was submitted) behavior,
just that this issue was discovered recently by some customer environment.
Let me know if you want me to put one of those initial driver commit tag here and repost ? 

Thanks,
Manish