netdev - Re: [PATCH net] net: stmmac: Disable Tx queues when reconfiguring the interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211123200751.3de326e6@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 23 Nov 2021 20:07:51 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Yannick Vignon <yannick.vignon@....nxp.com>
Cc:     Giuseppe Cavallaro <peppe.cavallaro@...com>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        Jose Abreu <joabreu@...opsys.com>,
        "David S. Miller" <davem@...emloft.net>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        netdev@...r.kernel.org, Xiaoliang Yang <xiaoliang.yang_1@....com>,
        Kurt Kanzenbach <kurt.kanzenbach@...utronix.de>,
        Vladimir Oltean <vladimir.oltean@....com>,
        Ong Boon Leong <boon.leong.ong@...el.com>,
        Joakim Zhang <qiangqing.zhang@....com>,
        sebastien.laveze@....nxp.com,
        Yannick Vignon <yannick.vignon@....com>
Subject: Re: [PATCH net] net: stmmac: Disable Tx queues when reconfiguring
 the interface

On Tue, 23 Nov 2021 19:54:48 +0100 Yannick Vignon wrote:
> From: Yannick Vignon <yannick.vignon@....com>
> 
> The Tx queues were not disabled in cases where the driver needed to stop
> the interface to apply a new configuration. This could result in a kernel
> panic when doing any of the 3 following actions:
> * reconfiguring the number of queues (ethtool -L)
> * reconfiguring the size of the ring buffers (ethtool -G)
> * installing/removing an XDP program (ip l set dev ethX xdp)
> 
> Prevent the panic by making sure netif_tx_disable is called when stopping
> an interface.
> 
> Without this patch, the following kernel panic can be observed when loading
> an XDP program:
> 
> Unable to handle kernel paging request at virtual address ffff80001238d040
> [....]
>  Call trace:
>   dwmac4_set_addr+0x8/0x10
>   dev_hard_start_xmit+0xe4/0x1ac
>   sch_direct_xmit+0xe8/0x39c
>   __dev_queue_xmit+0x3ec/0xaf0
>   dev_queue_xmit+0x14/0x20
> [...]
> [ end trace 0000000000000002 ]---
> 
> Fixes: 78cb988d36b6 ("net: stmmac: Add initial XDP support")
> Signed-off-by: Yannick Vignon <yannick.vignon@....com>

Fixes tag: Fixes: 78cb988d36b6 ("net: stmmac: Add initial XDP support")
Has these problem(s):
	- Target SHA1 does not exist