netdev - Re: [PATCH net 1/2] net/smc: Keep smc_close

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48002af6-63ca-edd3-dd71-b66032baeeb3@linux.ibm.com>
Date:   Thu, 25 Nov 2021 11:51:46 +0100
From:   Karsten Graul <kgraul@...ux.ibm.com>
To:     netdev@...r.kernel.org
Cc:     kuba@...nel.org, davem@...emloft.net, linux-s390@...r.kernel.org,
        linux-rdma@...r.kernel.org, Tony Lu <tonylu@...ux.alibaba.com>
Subject: Re: [PATCH net 1/2] net/smc: Keep smc_close_final rc during active
 close

On 25/11/2021 07:19, Tony Lu wrote:
> When smc_close_final() returns error, the return code overwrites by
> kernel_sock_shutdown() in smc_close_active(). The return code of
> smc_close_final() is more important than kernel_sock_shutdown(), and it
> will pass to userspace directly.
> 
> Fix it by keeping both return codes, if smc_close_final() raises an
> error, return it or kernel_sock_shutdown()'s.
> 
> Link: https://lore.kernel.org/linux-s390/1f67548e-cbf6-0dce-82b5-10288a4583bd@linux.ibm.com/
> Fixes: 606a63c9783a ("net/smc: Ensure the active closing peer first closes clcsock")
> Suggested-by: Karsten Graul <kgraul@...ux.ibm.com>
> Signed-off-by: Tony Lu <tonylu@...ux.alibaba.com>
> Reviewed-by: Wen Gu <guwen@...ux.alibaba.com>
> ---

Acked-by: Karsten Graul <kgraul@...ux.ibm.com>