netdev - Re: [PATCH net-next 05/12] iavf: don't be so alarming

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211125064515.wjoe4evnqdfy62c7@x230>
Date:   Thu, 25 Nov 2021 07:45:15 +0100
From:   Stefan Assmann <sassmann@...hat.com>
To:     Tony Nguyen <anthony.l.nguyen@...el.com>
Cc:     davem@...emloft.net, kuba@...nel.org,
        Mitch Williams <mitch.a.williams@...el.com>,
        netdev@...r.kernel.org,
        George Kuruvinakunnel <george.kuruvinakunnel@...el.com>
Subject: Re: [PATCH net-next 05/12] iavf: don't be so alarming

On 2021-11-24 09:16, Tony Nguyen wrote:
> From: Mitch Williams <mitch.a.williams@...el.com>
> 
> Reduce the log level of a couple of messages. These can appear during normal
> reset and rmmod processing, and the driver recovers just fine. Debug
> level is fine for these.
> 
> Signed-off-by: Mitch Williams <mitch.a.williams@...el.com>
> Tested-by: George Kuruvinakunnel <george.kuruvinakunnel@...el.com>
> Signed-off-by: Tony Nguyen <anthony.l.nguyen@...el.com>
> ---
>  drivers/net/ethernet/intel/iavf/iavf_main.c     | 2 +-
>  drivers/net/ethernet/intel/iavf/iavf_virtchnl.c | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c b/drivers/net/ethernet/intel/iavf/iavf_main.c
> index cc1b3caa5136..bb2e91cb9cd4 100644
> --- a/drivers/net/ethernet/intel/iavf/iavf_main.c
> +++ b/drivers/net/ethernet/intel/iavf/iavf_main.c
> @@ -3405,7 +3405,7 @@ static int iavf_close(struct net_device *netdev)
>  				    adapter->state == __IAVF_DOWN,
>  				    msecs_to_jiffies(500));
>  	if (!status)
> -		netdev_warn(netdev, "Device resources not yet released\n");
> +		netdev_dbg(netdev, "Device resources not yet released\n");
>  	return 0;

This message in particular has been a good indicator for some irregular
behaviour in VF reset. I'd rather keep it the way it is or change it
netdev_info().

  Stefan