netdev - Re: [PATCH ipsec] xfrm: fix dflt policy check when there is no policy configured

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5a22e114-f12e-38df-daf2-8ea39dc1f60d@6wind.com>
Date:   Thu, 25 Nov 2021 09:23:15 +0100
From:   Nicolas Dichtel <nicolas.dichtel@...nd.com>
To:     antony.antony@...unet.com
Cc:     steffen.klassert@...unet.com, davem@...emloft.net,
        herbert@...dor.apana.org.au, kuba@...nel.org,
        netdev@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH ipsec] xfrm: fix dflt policy check when there is no policy
 configured

Le 25/11/2021 à 07:57, Antony Antony a écrit :
> Hi Nicolas,
Hi Antony,

> 
> On Mon, Nov 22, 2021 at 11:33:13 +0100, Nicolas Dichtel wrote:
>> When there is no policy configured on the system, the default policy is
>> checked in xfrm_route_forward. However, it was done with the wrong
>> direction (XFRM_POLICY_FWD instead of XFRM_POLICY_OUT).
> 
> How can I reproduce this? 
> I tried adding fwd block and no policy and that blocked the forwarded traffic.
> I ran into another issue with fwd block and and tunnel. I will double check. Next week.
> 
With the out default policy set to 'block' and no out policy configured, the
packets are forwarded. After my patch, packets are blocked:

$ ip xfrm policy getdefault
Default policies:
 in:  accept
 fwd: accept
 out: block
$ ip xfrm policy
$


Regards,
Nicolas