netdev - Re: [PATCH 1/2] Docs/devicetree: add serdes-output-amplitude to marvell.txt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YaFqafEDK8Fdub9q@lunn.ch>
Date:   Sat, 27 Nov 2021 00:14:49 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Holger Brunck <holger.brunck@...achienergy.com>
Cc:     netdev@...r.kernel.org, Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH 1/2] Docs/devicetree: add serdes-output-amplitude to
 marvell.txt

> @@ -46,6 +46,9 @@ Optional properties:
>  - mdio?		: Container of PHYs and devices on the external MDIO
>  			  bus. The node must contains a compatible string of
>  			  "marvell,mv88e6xxx-mdio-external"
> +- serdes-output-amplitude: Configure the output amplitude of the serdes
> +			   interface.
> +    serdes-output-amplitude = <MV88E6352_SERDES_OUT_AMP_210MV>;

I checked a couple of Marvell PHY datasheets. The 1510, 1512, and 1518
have the exact same register/bits. So ideally we want DT property name
which somebody can later reuse in the Marvell PHY
driver. serdes-output-amplitude-mv seems O.K. for that.

	Andrew