netdev - RE: [PATCH 1/2] Docs/devicetree: add serdes-output-amplitude to marvell.txt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM0PR0602MB3666EC417E29AEC402E29055F7669@AM0PR0602MB3666.eurprd06.prod.outlook.com>
Date:   Mon, 29 Nov 2021 10:40:09 +0000
From:   Holger Brunck <holger.brunck@...achienergy.com>
To:     Andrew Lunn <andrew@...n.ch>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Jakub Kicinski <kuba@...nel.org>,
        Marek Behún <kabel@...nel.org>
Subject: RE: [PATCH 1/2] Docs/devicetree: add serdes-output-amplitude to
 marvell.txt

> On Fri, Nov 26, 2021 at 04:42:48PM +0100, Holger Brunck wrote:
> > This can be configured from the device tree. Add this property to the
> > documentation accordingly.
> > The eight different values added in the dt-bindings file correspond to
> > the values we can configure on 88E6352, 88E6240 and 88E6176 switches
> > according to the datasheet.
> >
> > CC: Andrew Lunn <andrew@...n.ch>
> > CC: Jakub Kicinski <kuba@...nel.org>
> > Signed-off-by: Holger Brunck <holger.brunck@...achienergy.com>
> > ---
> >  .../devicetree/bindings/net/dsa/marvell.txt    |  3 +++
> >  include/dt-bindings/net/mv-88e6xxx.h           | 18 ++++++++++++++++++
> >  2 files changed, 21 insertions(+)
> >  create mode 100644 include/dt-bindings/net/mv-88e6xxx.h
> >
> > diff --git a/Documentation/devicetree/bindings/net/dsa/marvell.txt
> > b/Documentation/devicetree/bindings/net/dsa/marvell.txt
> > index 2363b412410c..bff397a2dc49 100644
> > --- a/Documentation/devicetree/bindings/net/dsa/marvell.txt
> > +++ b/Documentation/devicetree/bindings/net/dsa/marvell.txt
> > @@ -46,6 +46,9 @@ Optional properties:
> >  - mdio?              : Container of PHYs and devices on the external MDIO
> >                         bus. The node must contains a compatible string of
> >                         "marvell,mv88e6xxx-mdio-external"
> > +- serdes-output-amplitude: Configure the output amplitude of the serdes
> > +                        interface.
> > +    serdes-output-amplitude = <MV88E6352_SERDES_OUT_AMP_210MV>;
> 
> Please make this actually millivolts, not an enum. Have the property called
> serdes-output-amplitude-mv. The driver should convert from a mv value to
> whatever value you need to write to the register, or return -EINVAL.
> 

ok I will change that.

Best regards
Holger