netdev - RE: [PATCH 1/2] Docs/devicetree: add serdes-output-amplitude to marvell.txt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM0PR0602MB366691E7FAB1C546B3E8F832F7669@AM0PR0602MB3666.eurprd06.prod.outlook.com>
Date:   Mon, 29 Nov 2021 11:14:02 +0000
From:   Holger Brunck <holger.brunck@...achienergy.com>
To:     Andrew Lunn <andrew@...n.ch>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Jakub Kicinski <kuba@...nel.org>,
        Marek Behún <kabel@...nel.org>
Subject: RE: [PATCH 1/2] Docs/devicetree: add serdes-output-amplitude to
 marvell.txt

> 
> On Fri, Nov 26, 2021 at 04:42:48PM +0100, Holger Brunck wrote:
> > This can be configured from the device tree. Add this property to the
> > documentation accordingly.
> > The eight different values added in the dt-bindings file correspond to
> > the values we can configure on 88E6352, 88E6240 and 88E6176 switches
> > according to the datasheet.
> 
> This should probably be a port property, not a switch property. It applies to the
> SERDES, and the SERDES belongs to a port. What you have now only works
> because there is a single SERDES for this switch family, but other switch families
> have multiple SERDESes.
> 

yes you are right it is more a port property. So I will try to parse the DT node for
the port and add the property there. But in this case I need to double check that
the specific port is the one supporting this feature. Not sure yet how to do that, 
I need to check. Also I will move the parsing out of mv88e6xxx_setup to
mv88e6xxx_setup_port then.

Best regards
Holger