netdev - Re: [PATCH] rtw89: remove unneeded conversion to bool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 29 Nov 2021 10:41:25 +0000 (UTC)
From:   Kalle Valo <kvalo@...eaurora.org>
To:     davidcomponentone@...il.com
Cc:     pkshih@...ltek.com, davidcomponentone@...il.com,
        davem@...emloft.net, kuba@...nel.org,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, Yang Guang <yang.guang5@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH] rtw89: remove unneeded conversion to bool

davidcomponentone@...il.com wrote:

> From: Yang Guang <yang.guang5@....com.cn>
> 
> The coccinelle report
> ./drivers/net/wireless/realtek/rtw89/debug.c:817:21-26:
> WARNING: conversion to bool not needed here
> ./drivers/net/wireless/realtek/rtw89/mac.c:3698:49-54:
> WARNING: conversion to bool not needed here
> ./drivers/net/wireless/realtek/rtw89/phy.c:1770:49-54:
> WARNING: conversion to bool not needed here
> ./drivers/net/wireless/realtek/rtw89/rtw8852a.c:1056:41-46:
> WARNING: conversion to bool not needed here
> 
> Relational and logical operators evaluate to bool,
> explicit conversion is overly verbose and unneeded.
> 
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Yang Guang <yang.guang5@....com.cn>

There was a similar patch already applied:

https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git/commit/?id=1646ce8f83b9

Patch set to Superseded.

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/d9492bb9bced106f20006edb49200926184c3763.1637739090.git.yang.guang5@zte.com.cn/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches