netdev - Re: [PATCH net 6/6] net: dsa: mv88e6xxx: Link in pcs_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YaVeyWsGd06eRUqv@shell.armlinux.org.uk>
Date:   Mon, 29 Nov 2021 23:14:17 +0000
From:   "Russell King (Oracle)" <linux@...linux.org.uk>
To:     Marek Behún <kabel@...nel.org>
Cc:     netdev@...r.kernel.org, Andrew Lunn <andrew@...n.ch>,
        Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net
Subject: Re: [PATCH net 6/6] net: dsa: mv88e6xxx: Link in pcs_get_state() if
 AN is bypassed

On Mon, Nov 29, 2021 at 08:58:23PM +0100, Marek Behún wrote:
>  static int mv88e6xxx_serdes_pcs_get_state(struct mv88e6xxx_chip *chip,
> -					  u16 status, u16 lpa,
> +					  u16 ctrl, u16 status, u16 lpa,
>  					  struct phylink_link_state *state)
>  {
> +	state->link = !!(status & MV88E6390_SGMII_PHY_STATUS_LINK);
> +
>  	if (status & MV88E6390_SGMII_PHY_STATUS_SPD_DPL_VALID) {
> -		state->link = !!(status & MV88E6390_SGMII_PHY_STATUS_LINK);
> +		state->an_complete = !!(ctrl & BMCR_ANENABLE);

I think I'd much rather report the value of BMSR_ANEGCAPABLE - since
an_complete controls the BMSR_ANEGCAPABLE bit in the emulated PHY
that userspace sees. Otherwise, an_complete is not used.

state->link is the key that phylink uses to know whether it can
trust the status being reported.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!