netdev - Re: [PATCH net 3/6] net: dsa: mv88e6xxx: Save power by disabling SerDes trasmitter and receiver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211130011328.42328281@thinkpad>
Date:   Tue, 30 Nov 2021 01:13:28 +0100
From:   Marek Behún <kabel@...nel.org>
To:     "Russell King (Oracle)" <linux@...linux.org.uk>
Cc:     netdev@...r.kernel.org, Andrew Lunn <andrew@...n.ch>,
        Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net
Subject: Re: [PATCH net 3/6] net: dsa: mv88e6xxx: Save power by disabling
 SerDes trasmitter and receiver

On Mon, 29 Nov 2021 23:06:38 +0000
"Russell King (Oracle)" <linux@...linux.org.uk> wrote:

> On Mon, Nov 29, 2021 at 08:58:20PM +0100, Marek Behún wrote:
> > +static int mv88e6393x_serdes_power_lane(struct mv88e6xxx_chip *chip, int lane,
> > +					bool on)
> > +{
> > +	u16 reg;
> > +	int err;
> > +
> > +	err = mv88e6390_serdes_read(chip, lane, MDIO_MMD_PHYXS,
> > +				    MV88E6393X_SERDES_CTRL1, &reg);
> > +	if (err)
> > +		return err;
> > +
> > +	if (on)
> > +		reg &= !(MV88E6393X_SERDES_CTRL1_TX_PDOWN |
> > +			 MV88E6393X_SERDES_CTRL1_RX_PDOWN);  
> 
> Are you sure this is correct? Don't you want that to be ~(...) ?
> 

/o\ How did I not notice this? Thanks.