netdev - Re: [PATCH 2/2 -net] natsemi: xtensa: fix section mismatch warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMo8Bf+0SUnc6FqSziykcr6GEhHp6-xtgk+_TKukhn+gTc6CEg@mail.gmail.com>
Date:   Tue, 30 Nov 2021 06:21:40 -0800
From:   Max Filippov <jcmvbkbc@...il.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     netdev <netdev@...r.kernel.org>, kernel test robot <lkp@...el.com>,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        Finn Thain <fthain@...egraphics.com.au>,
        Chris Zankel <chris@...kel.net>,
        "open list:TENSILICA XTENSA PORT (xtensa)" 
        <linux-xtensa@...ux-xtensa.org>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH 2/2 -net] natsemi: xtensa: fix section mismatch warnings

On Mon, Nov 29, 2021 at 10:39 PM Randy Dunlap <rdunlap@...radead.org> wrote:
>
> Fix section mismatch warnings in xtsonic. The first one appears to be
> bogus and after fixing the second one, the first one is gone.
>
> WARNING: modpost: vmlinux.o(.text+0x529adc): Section mismatch in reference from the function sonic_get_stats() to the function .init.text:set_reset_devices()
> The function sonic_get_stats() references
> the function __init set_reset_devices().
> This is often because sonic_get_stats lacks a __init
> annotation or the annotation of set_reset_devices is wrong.
>
> WARNING: modpost: vmlinux.o(.text+0x529b3b): Section mismatch in reference from the function xtsonic_probe() to the function .init.text:sonic_probe1()
> The function xtsonic_probe() references
> the function __init sonic_probe1().
> This is often because xtsonic_probe lacks a __init
> annotation or the annotation of sonic_probe1 is wrong.
>
> Fixes: 74f2a5f0ef64 ("xtensa: Add support for the Sonic Ethernet device for the XT2000 board.")

The original code had the __devinit attribute
for the function xtsonic_probe, it then was dropped in change
6980cbe4a6db ("natsemi: remove __dev* attributes").
I'd say that this is the change that this patch fixes.

> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Reported-by: kernel test robot <lkp@...el.com>
> ---
>  drivers/net/ethernet/natsemi/xtsonic.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Max Filippov <jcmvbkbc@...il.com>

-- 
Thanks.
-- Max