netdev - Re: [PATCH net-next 2/7] net: wwan: iosm: set tx queue len

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 5 Dec 2021 16:59:54 +0300
From:   Sergey Ryazanov <ryazanov.s.a@...il.com>
To:     "Kumar, M Chetan" <m.chetan.kumar@...ux.intel.com>
Cc:     netdev@...r.kernel.org, Jakub Kicinski <kuba@...nel.org>,
        David Miller <davem@...emloft.net>,
        Johannes Berg <johannes@...solutions.net>,
        Loic Poulain <loic.poulain@...aro.org>,
        krishna.c.sudi@...el.com,
        M Chetan Kumar <m.chetan.kumar@...el.com>,
        Intel Corporation <linuxwwan@...el.com>
Subject: Re: [PATCH net-next 2/7] net: wwan: iosm: set tx queue len

On Sun, Dec 5, 2021 at 4:52 PM Kumar, M Chetan
<m.chetan.kumar@...ux.intel.com> wrote:
> On 12/5/2021 4:46 PM, Sergey Ryazanov wrote:
>> On Sun, Dec 5, 2021 at 9:47 AM M Chetan Kumar
>> <m.chetan.kumar@...ux.intel.com> wrote:
>>> Set wwan net dev tx queue len to 1000.
>>>
>>> Signed-off-by: M Chetan Kumar <m.chetan.kumar@...ux.intel.com>
>>> ---
>>>   drivers/net/wwan/iosm/iosm_ipc_wwan.c | 3 ++-
>>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/net/wwan/iosm/iosm_ipc_wwan.c b/drivers/net/wwan/iosm/iosm_ipc_wwan.c
>>> index b571d9cedba4..e3fb926d2248 100644
>>> --- a/drivers/net/wwan/iosm/iosm_ipc_wwan.c
>>> +++ b/drivers/net/wwan/iosm/iosm_ipc_wwan.c
>>> @@ -18,6 +18,7 @@
>>>   #define IOSM_IP_TYPE_IPV6 0x60
>>>
>>>   #define IOSM_IF_ID_PAYLOAD 2
>>> +#define IOSM_QDISC_QUEUE_LEN 1000
>>
>> Is this 1000 something special for the IOSM driver? If you need just
>> an approximate value for the queue length, then consider using the
>> common DEFAULT_TX_QUEUE_LEN macro, please.
>> We had set an approximate value for the queue length.
> Sure, will use the common queue length macro (DEFAULT_TX_QUEUE_LEN)
> instead of defining the new macro.

Thank you! The series looks good to me, so feel free to add my:

Reviewed-by: Sergey Ryazanov <ryazanov.s.a@...il.com>