netdev - Re: [PATCH v2 0/3] drivers/net: split FEC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Ya4Q9aysfYwV35MO@lunn.ch>
Date:   Mon, 6 Dec 2021 14:32:37 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Apeksha Gupta <apeksha.gupta@....com>
Cc:     qiangqing.zhang@....com, netdev@...r.kernel.org, kuba@...nel.org,
        arnd@...db.de, linux-kernel@...r.kernel.org,
        linux-devel@...ux.nxdi.nxp.com, LnxRevLi@....com,
        sachin.saxena@....com, hemant.agrawal@....com
Subject: Re: [PATCH v2 0/3] drivers/net: split FEC driver

On Mon, Dec 06, 2021 at 10:25:33AM +0530, Apeksha Gupta wrote:
> This patch series is to restructure the FEC (Fast Ethernet Controller)
> driver. All PHY functionality moved from fec_main.c to separate files
> fec_phy.h and fec_phy.c. By these changes FEC driver become more
> flexible to work with other PHY drivers whenever required in future.

The MAC driver has little to do with the PHY driver. All PHY driver
details are in the actual PHY driver and phylib. At minimum we need to
see these other PHY driver changes, so you can justify this change.

What i think you are trying to do is sneak in the changes you need for
DPDK. Please don't so that. Just implement XDP.

NACK

      Andrew