netdev - RE: [RFC PATCH 4/4] r8169: add sysfs for dash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2f5c720b6f3b46648678bee05eb23787@realtek.com>
Date:   Tue, 7 Dec 2021 06:53:06 +0000
From:   Hayes Wang <hayeswang@...ltek.com>
To:     Heiner Kallweit <hkallweit1@...il.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        nic_swsd <nic_swsd@...ltek.com>
Subject: RE: [RFC PATCH 4/4] r8169: add sysfs for dash

Heiner Kallweit <hkallweit1@...il.com>
> Sent: Friday, December 3, 2021 11:15 PM
[...]
> With regard to sysfs usage:
> - attributes should be documented under /Documentation/ABI/testing
> - attributes should be defined statically (driver.dev_groups instead
>   of sysfs_create_group)
> - for printing info there's sysfs_emit()
> - is really RTNL needed? Or would a lighter mutex do?

In addition to protect the critical section, RTNL is used to avoid
calling close() before CMAC is finished. The transfer of CMAC
may contain several steps. And close() would disable CMAC.
I don't wish the CMAC stays at strange state. It may influence
the firmware or hardware. Besides, I find the original driver only
use RTNL to protect critical section. Is there a better way for it?

Best Regards,
Hayes