netdev - Re: [PATCH net-next v2 4/4] net: wwan: make debugfs optional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Ya8Up73OsIsPnNJN@unreal>
Date:   Tue, 7 Dec 2021 10:00:39 +0200
From:   Leon Romanovsky <leon@...nel.org>
To:     Sergey Ryazanov <ryazanov.s.a@...il.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        M Chetan Kumar <m.chetan.kumar@...el.com>,
        Intel Corporation <linuxwwan@...el.com>,
        Loic Poulain <loic.poulain@...aro.org>,
        Johannes Berg <johannes@...solutions.net>
Subject: Re: [PATCH net-next v2 4/4] net: wwan: make debugfs optional

On Tue, Dec 07, 2021 at 02:41:55AM +0300, Sergey Ryazanov wrote:
> Debugfs interface is optional for the regular modem use. Some distros
> and users will want to disable this feature for security or kernel
> size reasons. So add a configuration option that allows to completely
> disable the debugfs interface of the WWAN devices.
> 
> A primary considered use case for this option was embedded firmwares.
> For example, in OpenWrt, you can not completely disable debugfs, as a
> lot of wireless stuff can only be configured and monitored with the
> debugfs knobs. At the same time, reducing the size of a kernel and
> modules is an essential task in the world of embedded software.
> Disabling the WWAN and IOSM debugfs interfaces allows us to save 50K
> (x86-64 build) of space for module storage. Not much, but already
> considerable when you only have 16MB of storage.
> 
> So it is hard to just disable whole debugfs. Users need some fine
> grained set of options to control which debugfs interface is important
> and should be available and which is not.
> 
> The new configuration symbol is enabled by default and is hidden under
> the EXPERT option. So a regular user would not be bothered by another
> one configuration question. While an embedded distro maintainer will be
> able to a little more reduce the final image size.
> 
> Signed-off-by: Sergey Ryazanov <ryazanov.s.a@...il.com>
> ---

Thanks,
Reviewed-by: Leon Romanovsky <leonro@...dia.com>