netdev - Re: [PATCH net] ethtool: do not perform operations on net devices being unregistered

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <163886433967.108321.10984889226841148462@kwain>
Date:   Tue, 07 Dec 2021 09:05:39 +0100
From:   Antoine Tenart <atenart@...nel.org>
To:     Jakub Kicinski <kuba@...nel.org>,
        Julian Wiedmann <jwi@...ux.ibm.com>
Cc:     davem@...emloft.net, alexander.duyck@...il.com, mkubecek@...e.cz,
        netdev@...r.kernel.org
Subject: Re: [PATCH net] ethtool: do not perform operations on net devices being unregistered

Quoting Jakub Kicinski (2021-12-06 16:15:20)
> On Mon, 6 Dec 2021 11:46:35 +0200 Julian Wiedmann wrote:
> > 
> > Wondering if other places would also benefit from a netif_device_detach()
> > in the unregistration sequence ...
> 
> Sounds like a good idea but maybe as a follow up to net-next? 
> The likelihood of that breaking things is low, but non-zero.

Might be good to have a look at this yes. I'm wondering, there are
multiple mechanisms to avoid using a net device after unregistration,
including netif_device_detach and unlinking it from the device chain
(unlist_netdevice). Currently it's possible to have a device unlinked
but not detached. Haven't looked at it, but there might be something to
do here.

(One the other way, detaching a device without unlinking it is valid for
PM).

Antoine