netdev - Re: [PATCH RFC net] net: dsa: mv88e6xxx: allow use of PHYs on CPU and DSA ports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Ya9abXJELHCaBE0k@shell.armlinux.org.uk>
Date:   Tue, 7 Dec 2021 12:58:21 +0000
From:   "Russell King (Oracle)" <linux@...linux.org.uk>
To:     Martyn Welch <martyn.welch@...labora.com>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org
Subject: Re: [PATCH RFC net] net: dsa: mv88e6xxx: allow use of PHYs on CPU
 and DSA ports

On Tue, Dec 07, 2021 at 12:47:35PM +0000, Martyn Welch wrote:
> Sorry Russell, but unfortunately this patch doesn't seem to be
> resolving the issue for me.
> 
> I've dumped in a bit of debug around this change to see if I could
> determine what was going on here, it seems that in my case the function
> is being exited before this at:
> 
> /* FIXME: is this the correct test? If we're in fixed mode on an
>  * internal port, why should we process this any different from
>  * PHY mode? On the other hand, the port may be automedia between
>  * an internal PHY and the serdes...
>  */
> if ((mode == MLO_AN_PHY) && mv88e6xxx_phy_is_internal(ds, port))
>         return;

Oh, I was going to remove that, but clearly forgot, sorry. Please can
you try again with that removed? Meanwhile, I'll update the patch at
my end.

Thanks.
-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!