netdev - Re: [PATCH net-next] net: x25: drop harmless check of !more

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <591bfc0470ca596995e13337460f99d0@dev.tdt.de>
Date:   Wed, 08 Dec 2021 08:51:17 +0100
From:   Martin Schiller <ms@....tdt.de>
To:     Jεan Sacren <sakiwit@...il.com>
Cc:     davem@...emloft.net, kuba@...nel.org, linux-x25@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: x25: drop harmless check of !more

On 2021-12-08 08:20, Jεan Sacren wrote:
> From: Jean Sacren <sakiwit@...il.com>
> 
> 'more' is checked first.  When !more is checked immediately after that,
> it is always true.  We should drop this check.
> 
> Signed-off-by: Jean Sacren <sakiwit@...il.com>
> ---
>  net/x25/x25_in.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/x25/x25_in.c b/net/x25/x25_in.c
> index e1c4197af468..b981a4828d08 100644
> --- a/net/x25/x25_in.c
> +++ b/net/x25/x25_in.c
> @@ -41,7 +41,7 @@ static int x25_queue_rx_frame(struct sock *sk,
> struct sk_buff *skb, int more)
>  		return 0;
>  	}
> 
> -	if (!more && x25->fraglen > 0) {	/* End of fragment */
> +	if (x25->fraglen > 0) {	/* End of fragment */
>  		int len = x25->fraglen + skb->len;
> 
>  		if ((skbn = alloc_skb(len, GFP_ATOMIC)) == NULL){

Acked-by: Martin Schiller <ms@....tdt.de>