netdev - Re: [PATCH net-next v5] rtnetlink: Support fine-grained netdevice bulk deletion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211208215033.dston6q4cvpxsjxq@kgollan-pc>
Date:   Wed, 8 Dec 2021 23:50:34 +0200
From:   Lahav Schlesinger <lschlesinger@...venets.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     David Ahern <dsahern@...il.com>, netdev@...r.kernel.org,
        nikolay@...dia.com
Subject: Re: [PATCH net-next v5] rtnetlink: Support fine-grained netdevice
 bulk deletion

On Tue, Dec 07, 2021 at 07:37:15AM -0800, Jakub Kicinski wrote:
> CAUTION: External E-Mail - Use caution with links and attachments
>
>
> On Mon, 6 Dec 2021 21:12:33 -0700 David Ahern wrote:
> > The need to walk the list twice (3 really with the sort) to means the
> > array solution is better.
>
> Technically the linear walk will be dwarfed by the sort for non-trivial
> inputs (have I been conducting too many coding interviews?)
>
> Especially with retpolines :(
>
> > I liked the array variant better. Jakub?
>
> I always default to attr-per-member unless there is a strong constraint
> on message size. Trying to extend old school netlink (TC etc) left me
> scarred. But we can do array, no big deal.

Thanks, I'll send a new patch with array API and all previous comments