netdev - Re: [PATCH net 7/7] ice: safer stats processing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7fef56c5-b3bf-4aad-4f29-adfaf2b902b9@intel.com>
Date:   Wed, 8 Dec 2021 14:00:06 -0800
From:   Jesse Brandeburg <jesse.brandeburg@...el.com>
To:     Jakub Kicinski <kuba@...nel.org>,
        Tony Nguyen <anthony.l.nguyen@...el.com>
CC:     <davem@...emloft.net>, <netdev@...r.kernel.org>,
        <stephen@...workplumber.org>,
        Gurucharan G <gurucharanx.g@...el.com>
Subject: Re: [PATCH net 7/7] ice: safer stats processing

On 12/7/2021 9:58 PM, Jakub Kicinski wrote:
>> @@ -6219,6 +6227,7 @@ void ice_get_stats64(struct net_device *netdev, struct rtnl_link_stats64 *stats)
>>   	 */
>>   	if (!test_bit(ICE_VSI_DOWN, vsi->state))
>>   		ice_update_vsi_ring_stats(vsi);
>> +
>>   	stats->tx_packets = vsi_stats->tx_packets;
>>   	stats->tx_bytes = vsi_stats->tx_bytes;
>>   	stats->rx_packets = vsi_stats->rx_packets;
> 
> 🙄 in a fix that has to go back to 4.16?

Whoops! Yeah, that was my bad. Looks like I owe Tony a beer, he already 
fixed it and sent a v2. Normally I'd mention whitespace changes like 
that in the commit message and not include those in a "Fixes" patch, but 
this one slipped through when I created it. Thanks for the review!