netdev - Re: [PATCH net 7/7] ice: safer stats processing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211207215853.692bbff4@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 7 Dec 2021 21:58:53 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Tony Nguyen <anthony.l.nguyen@...el.com>
Cc:     davem@...emloft.net, Jesse Brandeburg <jesse.brandeburg@...el.com>,
        netdev@...r.kernel.org, stephen@...workplumber.org,
        Gurucharan G <gurucharanx.g@...el.com>
Subject: Re: [PATCH net 7/7] ice: safer stats processing

On Tue,  7 Dec 2021 14:25:44 -0800 Tony Nguyen wrote:
> @@ -5949,6 +5950,7 @@ ice_update_vsi_tx_ring_stats(struct ice_vsi *vsi, struct ice_tx_ring **rings,
>  			ice_fetch_u64_stats_per_ring(&ring->syncp, ring->stats, &pkts, &bytes);
>  		vsi_stats->tx_packets += pkts;
>  		vsi_stats->tx_bytes += bytes;
> +
>  		vsi->tx_restart += ring->tx_stats.restart_q;
>  		vsi->tx_busy += ring->tx_stats.tx_busy;
>  		vsi->tx_linearize += ring->tx_stats.tx_linearize;

> @@ -6219,6 +6227,7 @@ void ice_get_stats64(struct net_device *netdev, struct rtnl_link_stats64 *stats)
>  	 */
>  	if (!test_bit(ICE_VSI_DOWN, vsi->state))
>  		ice_update_vsi_ring_stats(vsi);
> +
>  	stats->tx_packets = vsi_stats->tx_packets;
>  	stats->tx_bytes = vsi_stats->tx_bytes;
>  	stats->rx_packets = vsi_stats->rx_packets;

🙄 in a fix that has to go back to 4.16?