netdev - Re: [PATCH] wilc1000: Remove misleading USE_SPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 14 Dec 2021 18:44:50 +0000 (UTC)
From:   Kalle Valo <kvalo@...nel.org>
To:     David Mosberger-Tang <davidm@...uge.net>
Cc:     Ajay Singh <ajay.kathat@...rochip.com>,
        Claudiu Beznea <claudiu.beznea@...rochip.com>,
        Kalle Valo <kvalo@...eaurora.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        David Mosberger-Tang <davidm@...uge.net>
Subject: Re: [PATCH] wilc1000: Remove misleading USE_SPI_DMA macro

David Mosberger-Tang <davidm@...uge.net> wrote:

> The USE_SPI_DMA macro name suggests that it could be set to 1 to
> control whether or not SPI DMA should be used.  However, that's not
> what it does.  If set to 1, it'll set the SPI messages'
> "is_dma_mapped" flag to true, even though the tx/rx buffers aren't
> actually DMA mapped by the driver.  In other words, setting this flag
> to 1 will break the driver.
> 
> Best to clean up this confusion by removing the macro altogether.
> There is no need to explicitly initialize "is_dma_mapped" because the
> message is cleared to zero anyhow, so "is_dma_mapped" is set to false
> by default.
> 
> Signed-off-by: David Mosberger-Tang <davidm@...uge.net>
> Acked-by: Ajay Singh <ajay.kathat@...rochip.com>

Patch applied to wireless-drivers-next.git, thanks.

dde02213fa64 wilc1000: Remove misleading USE_SPI_DMA macro

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20211207002453.3193737-1-davidm@egauge.net/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches