netdev - Re: [PATCH CFT net-next 1/2] net: axienet: convert to phylink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211216071513.6d1e0f55@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 16 Dec 2021 07:15:13 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     "Russell King (Oracle)" <rmk+kernel@...linux.org.uk>
Cc:     Michal Simek <michal.simek@...inx.com>,
        Radhey Shyam Pandey <radhey.shyam.pandey@...inx.com>,
        Sean Anderson <sean.anderson@...o.com>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH CFT net-next 1/2] net: axienet: convert to phylink_pcs

On Thu, 16 Dec 2021 12:48:45 +0000 Russell King (Oracle) wrote:
> Convert axienet to use the phylink_pcs layer, resulting in it no longer
> being a legacy driver.
> 
> One oddity in this driver is that lp->switch_x_sgmii controls whether
> we support switching between SGMII and 1000baseX. However, when clear,
> this also blocks updating the 1000baseX advertisement, which it
> probably should not be doing. Nevertheless, this behaviour is preserved
> but a comment is added.
> 
> Signed-off-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>

drivers/net/ethernet/xilinx/xilinx_axienet.h:479: warning: Function parameter or member 'pcs' not described in 'axienet_local'