netdev - Re: [PATCH v6, 2/2] net: Add dm9051 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211216071743.1de51554@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 16 Dec 2021 07:17:43 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Joseph CHAMG <josright123@...il.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Rob Herring <robh+dt@...nel.org>, joseph_chang@...icom.com.tw,
        netdev@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6, 2/2] net: Add dm9051 driver

On Thu, 16 Dec 2021 17:32:46 +0800 Joseph CHAMG wrote:
> Add davicom dm9051 spi ethernet driver, The driver work with the
> device platform's spi master
> 
> remove the redundant code that phylib has support,
> adjust to be the reasonable sequence,
> fine tune comments, add comments for pause function support
> 
> Tested with raspberry pi 4. Test for netwroking function, CAT5
> cable unplug/plug and also ethtool detect for link state, and
> all are ok.

Please install sparse and make sure the driver builds cleanly with W=1
C=1 flags.

drivers/net/ethernet/davicom/dm9051.c:349:26: warning: symbol 'dm9051_ethtool_ops' was not declared. Should it be static?
drivers/net/ethernet/davicom/dm9051.c:381:31: warning: incorrect type in initializer (different base types)
drivers/net/ethernet/davicom/dm9051.c:381:31:    expected int rxlen
drivers/net/ethernet/davicom/dm9051.c:381:31:    got restricted __le16 [usertype] rxlen
drivers/net/ethernet/davicom/dm9051.c:421:31: warning: restricted __le16 degrades to integer
drivers/net/ethernet/davicom/dm9051.c:426:23: warning: incorrect type in assignment (different base types)
drivers/net/ethernet/davicom/dm9051.c:426:23:    expected int rxlen
drivers/net/ethernet/davicom/dm9051.c:426:23:    got restricted __le16 [usertype] rxlen