netdev - Re: [PATCH] net: dsa: microchip: Add supported ksz9897 port6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <HK2PR03MB430766D15AD96E3F0E52A3D3E0789@HK2PR03MB4307.apcprd03.prod.outlook.com>
Date:   Fri, 17 Dec 2021 02:53:15 +0000
From:   KARL_TSOU (鄒磊) <KARL_TSOU@...QCONN.COM>
To:     Andrew Lunn <andrew@...n.ch>
CC:     "woojung.huh@...rochip.com" <woojung.huh@...rochip.com>,
        "UNGLinuxDriver@...rochip.com" <UNGLinuxDriver@...rochip.com>,
        "vivien.didelot@...il.com" <vivien.didelot@...il.com>,
        "f.fainelli@...il.com" <f.fainelli@...il.com>,
        "olteanv@...il.com" <olteanv@...il.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH] net: dsa: microchip: Add supported ksz9897 port6

The Microchip switch ksz9897 support 7 physical port, port 0/1/2/3/4 connect to standard RJ45, port5 connect to PHY via MII to CPU and port6 connect to PHY via RMII (PHY ksz8081) on my custom board.

I am facing a problem that I am not able to verify port6 via ping command even though the link is up, port 0/1/2/3/4 are all works fine by verifying with ping command expect port6

When I go through port initialization code, a "if condition" below that aren't included port6 initialization.

dev->phy_port_cnt = 5

# This allows port 0/1/2/3/4 but not 6
if (port < dev->phy_port_cnt)

# Add one more condition if port is not cpu port
if (port < dev->phy_port_cnt || !cpu_port)

# Add a if condition checking and updating for specified product and port number
if (dev->chip_id == 0x00989700 && i == 6)

Thanks
-Karl


From: Andrew Lunn <andrew@...n.ch>
Sent: Thursday, December 16, 2021 6:17 PM
To: KARL_TSOU (鄒磊) <KARL_TSOU@...QCONN.COM>
Cc: woojung.huh@...rochip.com <woojung.huh@...rochip.com>; UNGLinuxDriver@...rochip.com <UNGLinuxDriver@...rochip.com>; vivien.didelot@...il.com <vivien.didelot@...il.com>; f.fainelli@...il.com <f.fainelli@...il.com>; olteanv@...il.com <olteanv@...il.com>; davem@...emloft.net <davem@...emloft.net>; kuba@...nel.org <kuba@...nel.org>; netdev@...r.kernel.org <netdev@...r.kernel.org>
Subject: Re: [PATCH] net: dsa: microchip: Add supported ksz9897 port6 
 
On Thu, Dec 16, 2021 at 09:24:13AM +0000, KARL_TSOU (鄒磊) wrote:
> This fix driver ksz9897 port6 with PHY ksz8081 by hardware setup

Please explain in more details what the problem is you are fixing. It
is not clear from the code.

   Thanks
        Andrew