netdev - Re: [PATCH] net: dsa: microchip: Add supported ksz9897 port6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YbxfCkstuBOVI2e0@lunn.ch>
Date:   Fri, 17 Dec 2021 10:57:30 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     KARL_TSOU (鄒磊) <KARL_TSOU@...qconn.com>
Cc:     "woojung.huh@...rochip.com" <woojung.huh@...rochip.com>,
        "UNGLinuxDriver@...rochip.com" <UNGLinuxDriver@...rochip.com>,
        "vivien.didelot@...il.com" <vivien.didelot@...il.com>,
        "f.fainelli@...il.com" <f.fainelli@...il.com>,
        "olteanv@...il.com" <olteanv@...il.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH] net: dsa: microchip: Add supported ksz9897 port6

On Fri, Dec 17, 2021 at 02:53:15AM +0000, KARL_TSOU (鄒磊) wrote:
> The Microchip switch ksz9897 support 7 physical port, port 0/1/2/3/4 connect to standard RJ45, port5 connect to PHY via MII to CPU and port6 connect to PHY via RMII (PHY ksz8081) on my custom board.

Please don't top post. Also, wrap your emails so lines around 70
characters.

> I am facing a problem that I am not able to verify port6 via ping command even though the link is up, port 0/1/2/3/4 are all works fine by verifying with ping command expect port6
> 
> When I go through port initialization code, a "if condition" below that aren't included port6 initialization.

This initialization is for the internal PHYs. They have to
exist. External PHYs the switch driver should not assume exist. You
normally connect to the CPU directly, not via back to back PHYs. Any
there could be boards which use port 6 direct to the CPU without a
PHY. So this change as is, is wrong.

You should be using a phy-handle in DT for port6, or port5, to
indicate if a PHY is connected to the port. Do you have this property?

	 Andrew